Ensure node version matches parent pom#1601
Merged
gregorydlogan merged 28 commits intoMay 12, 2026
Merged
Conversation
In the access policy tab, when adding new roles, old roles would be removed. Basically, changing the roles in some manner would result in wonky behaviour. This patch fixes that, mostly by reverting 9d0a7b2 and making sure the policy key id is more reliable than index.
When sorting by a different column than before (e.g. by title instead of date), the sorting will now always be ascending first. Then on subsequent clicks on the same column you get descending and none. The goal for this patchis to improve the user experience through more intuitive behaviour.
When changing the template in the acl tab, if the current acl settings were invalid, a warning would appear *after* the template change about how the acl was invalid, when due to the template change it actually no longer wasn't. This fixes that.
Major version 26 has a breaking change that affects us, this patch should deal with that.
The maintenance window for node 20 is running out, we should probably update.
Memoization should prevent the dropdown options from getting recreated on every rerender. This should speed up non-dropdown related actions, such as adding new roles or changing access rights, on systems with many roles.
Improve acl tab performance for systems with many roles
Fix roles getting unselected in ACL tab
Bumps [actions/github-script](https://github.com/actions/github-script) from 7 to 9. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v7...v9) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: '9' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [react-tooltip](https://github.com/ReactTooltip/react-tooltip) from 5.30.1 to 6.0.0. - [Release notes](https://github.com/ReactTooltip/react-tooltip/releases) - [Changelog](https://github.com/ReactTooltip/react-tooltip/blob/master/CHANGELOG.md) - [Commits](ReactTooltip/react-tooltip@v5.30.1...v6.0.0) --- updated-dependencies: - dependency-name: react-tooltip dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…face into r/19.x Pull request opencast#1583 Always sort asc first for new column
Contributor
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
Contributor
|
This pull request is deployed at test.admin-interface.opencast.org/1601/2026-05-12_21-34-30/ . |
Member
Author
|
Note that this should be failing now, since the changes it makes depend on opencast/opencast#7636 being merged first. |
gregorydlogan
force-pushed
the
t/ensure-node-version
branch
from
0370dcb to
c9c227e
Compare
Opening one of the two about pages would crash the admin ui. This should fix that.
Pull request opencast#1607 Disable autofiling of PRs
…in-interface into r/19.x Pull request opencast#1584 Fix warning wrongly appearing on template change
…rface into r/19.x Pull request opencast#1602 Add translation for "Needs Cutting" filter
…e into r/19.x Pull request opencast#1603 Fix Imprint/Privacy page breaking the app
…nterface into develop Pull request opencast#1585 Update i18n to major version 26
…pencast/admin-interface into develop Pull request opencast#1591 Bump actions/github-script from 7 to 9
…t/admin-interface into develop Pull request opencast#1599 Bump react-tooltip from 5.30.1 to 6.0.0
… develop Pull request opencast#1586 Move to node 24 in gh workflows
gregorydlogan
force-pushed
the
t/ensure-node-version
branch
from
c9c227e to
8fd3004
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR checks to see that our node version matches the upstream parent's pom's version.
This has the side effect of updating the current version of node in use, especially once opencast/opencast#7636 is merged.